Commit 069970e1 authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

Reland "Update unicode-regexp-ignore-case-noi18n expectations"

This is a reland of c6c9d4bf

Original change's description:
> Update unicode-regexp-ignore-case-noi18n expectations
> 
> There appear to be one or several bugs in noi18n mode such that
> expectations in this test are no longer met. This CL updates
> expectations to the current behavior and re-enables the test so we at
> least preserve coverage in the other cases.
> 
> The behavior in question should be investigated in the future
> (low priority).
> 
> Bug: v8:10120
> Change-Id: Ib7c9a18133a386e6e39ee54d68ce4106d9b28c84
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2081815
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#66524}

Bug: v8:10120
Change-Id: Ib2ee68e26c2aebe2eeab3ec9f7bc263fd79f3773
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2083291
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66550}
parent 3e5abdc1
...@@ -140,8 +140,6 @@ ...@@ -140,8 +140,6 @@
############################################################################## ##############################################################################
['arch == arm64', { ['arch == arm64', {
'test-api/Bug618': [PASS],
# BUG(v8:3385). # BUG(v8:3385).
'test-serialize/StartupSerializerOnceRunScript': [PASS, FAIL], 'test-serialize/StartupSerializerOnceRunScript': [PASS, FAIL],
'test-serialize/StartupSerializerTwiceRunScript': [PASS, FAIL], 'test-serialize/StartupSerializerTwiceRunScript': [PASS, FAIL],
......
...@@ -29,11 +29,24 @@ assertFalse(/\u{10400}/ui.test("\u{10428}")); ...@@ -29,11 +29,24 @@ assertFalse(/\u{10400}/ui.test("\u{10428}"));
assertFalse(/\ud801\udc00/ui.test("\u{10428}")); assertFalse(/\ud801\udc00/ui.test("\u{10428}"));
assertFalse(/[\u{10428}]/ui.test("\u{10400}")); assertFalse(/[\u{10428}]/ui.test("\u{10400}"));
assertFalse(/[\ud801\udc28]/ui.test("\u{10400}")); assertFalse(/[\ud801\udc28]/ui.test("\u{10400}"));
assertEquals(["\uff21\u{10400}"],
/[\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc")); // TODO(v8:10120): Investigate why these don't behave as expected.
assertEquals(["abc"], /[^\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc\uff23")); {
assertEquals(["\uff53\u24bb"], // assertEquals(["\uff21\u{10400}"],
/[\u24d5-\uff33]+/ui.exec("\uff54\uff53\u24bb\u24ba")); // /[\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc"));
assertEquals(["\u{10400}"],
/[\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc"));
}
{
// assertEquals(["abc"], /[^\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc\uff23"));
assertEquals(["\u{ff21}"], /[^\uff40-\u{10428}]+/ui.exec("\uff21\u{10400}abc\uff23"));
}
{
// assertEquals(["\uff53\u24bb"],
// /[\u24d5-\uff33]+/ui.exec("\uff54\uff53\u24bb\u24ba"));
assertEquals(null,
/[\u24d5-\uff33]+/ui.exec("\uff54\uff53\u24bb\u24ba"));
}
// Full mappings are ignored. // Full mappings are ignored.
assertFalse(/\u00df/ui.test("SS")); assertFalse(/\u00df/ui.test("SS"));
......
...@@ -62,12 +62,6 @@ ...@@ -62,12 +62,6 @@
# Issue 9380: Memory leaks of shared WebAssembly.Memory objects # Issue 9380: Memory leaks of shared WebAssembly.Memory objects
'wasm/shared-memory-worker-gc': [SKIP], 'wasm/shared-memory-worker-gc': [SKIP],
# crbug.com/v8/10120: This test is meant to pass (only) in no_i18n builds,
# but currently doesn't:
'es6/unicode-regexp-ignore-case-noi18n': [FAIL],
# Once the bug is fixed, the expectations should be:
# 'es6/unicode-regexp-ignore-case-noi18n': [PASS, ['no_i18n == False', FAIL]],
# BUG(v8:10197) # BUG(v8:10197)
'regress/regress-748069': [SKIP], 'regress/regress-748069': [SKIP],
...@@ -160,6 +154,10 @@ ...@@ -160,6 +154,10 @@
# OOM with too many isolates/memory objects (https://crbug.com/1010272) # OOM with too many isolates/memory objects (https://crbug.com/1010272)
# Predictable tests fail due to race between postMessage and GrowMemory # Predictable tests fail due to race between postMessage and GrowMemory
'regress/wasm/regress-1010272': [PASS, NO_VARIANTS, ['system == android', SKIP], ['predictable', SKIP]], 'regress/wasm/regress-1010272': [PASS, NO_VARIANTS, ['system == android', SKIP], ['predictable', SKIP]],
# Only makes sense in the no_i18n variant.
'es6/unicode-regexp-ignore-case-noi18n':
[['no_i18n == True', PASS], ['no_i18n == False', FAIL]],
}], # ALWAYS }], # ALWAYS
############################################################################## ##############################################################################
...@@ -383,16 +381,17 @@ ...@@ -383,16 +381,17 @@
############################################################################## ##############################################################################
['no_i18n', { ['no_i18n', {
# case-insensitive unicode regexp relies on case mapping provided by ICU. # Case-insensitive unicode regexp relies on case mapping provided by ICU.
'es6/unicode-regexp-ignore-case': [FAIL], 'es6/unicode-regexp-ignore-case': [FAIL],
'regress/regress-5036': [FAIL], 'regress/regress-5036': [FAIL],
'es7/regexp-ui-word': [FAIL], 'es7/regexp-ui-word': [FAIL],
'regexp-modifiers-i18n': [FAIL], 'regexp-modifiers-i18n': [FAIL],
'regexp-modifiers-autogenerated-i18n': [FAIL], 'regexp-modifiers-autogenerated-i18n': [FAIL],
# desugaring regexp property class relies on ICU.
'harmony/regexp-property-*': [FAIL], # Desugaring regexp property class relies on ICU. Anything goes as long as we
'harmony/regexp-property-invalid': [PASS], # don't crash.
'regress/regress-793588': [FAIL], 'harmony/regexp-property-*': [PASS,FAIL],
'regress/regress-793588': [PASS,FAIL],
# noi18n build cannot parse characters in supplementary plane. # noi18n build cannot parse characters in supplementary plane.
'harmony/regexp-named-captures': [FAIL], 'harmony/regexp-named-captures': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment