Rename stress_flush_bytecode to stress_flush_code

stress_flush_bytecode controls stress flushing of both bytecode and
baseline code. So rename the flag to better reflect its functionality

Bug: v8:11947
Change-Id: Ie6c124a476c3a7c6eabd1d75de030ee15fe78e32
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3062567
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76043}

src/flags/flag-definitions.h

@@ -1253,9 +1253,9 @@ DEFINE_BOOL(flush_baseline_code, false,
 DEFINE_IMPLICATION(flush_baseline_code, flush_bytecode)
 DEFINE_BOOL(flush_bytecode, true,
             "flush of bytecode when it has not been executed recently")
-DEFINE_BOOL(stress_flush_bytecode, false, "stress bytecode flushing")
+DEFINE_BOOL(stress_flush_code, false, "stress code flushing")
 DEFINE_BOOL(trace_flush_bytecode, false, "trace bytecode flushing")
-DEFINE_IMPLICATION(stress_flush_bytecode, flush_bytecode)
+DEFINE_IMPLICATION(stress_flush_code, flush_bytecode)
 DEFINE_BOOL(use_marking_progress_bar, true,
             "Use a progress bar to scan large objects in increments when "
             "incremental marking is active.")

src/heap/heap-inl.h

@@ -102,7 +102,7 @@ base::EnumSet<CodeFlushMode> Heap::GetCodeFlushMode(Isolate* isolate) {
     code_flush_mode.Add(CodeFlushMode::kFlushBaselineCode);
   }
 
-  if (FLAG_stress_flush_bytecode) {
+  if (FLAG_stress_flush_code) {
     code_flush_mode.Add(CodeFlushMode::kStressFlushCode);
   }
 

test/cctest/test-web-snapshots.cc

@@ -423,7 +423,7 @@ TEST(SFIDeduplicationClasses) {
 }
 
 TEST(SFIDeduplicationAfterBytecodeFlushing) {
-  FLAG_stress_flush_bytecode = true;
+  FLAG_stress_flush_code = true;
   CcTest::InitializeVM();
   v8::Isolate* isolate = CcTest::isolate();
 
@@ -508,7 +508,7 @@ TEST(SFIDeduplicationAfterBytecodeFlushing) {
 }
 
 TEST(SFIDeduplicationAfterBytecodeFlushingClasses) {
-  FLAG_stress_flush_bytecode = true;
+  FLAG_stress_flush_code = true;
   CcTest::InitializeVM();
   v8::Isolate* isolate = CcTest::isolate();
 

test/debugger/debug/lazy-deopt-then-flush-bytecode.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --opt --noalways-opt --stress-flush-bytecode
+// Flags: --allow-natives-syntax --opt --noalways-opt --stress-flush-code
 // Flags: --expose-gc
 
 Debug = debug.Debug

test/debugger/debug/regress/regress-9067.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-gc --stress-flush-bytecode
+// Flags: --expose-gc --stress-flush-code
 
 var Debug = debug.Debug
 var bp;

test/inspector/cpu-profiler/coverage-block.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --no-always-opt --opt
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 // Flags: --no-stress-incremental-marking
 
 var source =

test/inspector/cpu-profiler/coverage.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --no-always-opt --opt
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 // Flags: --no-stress-incremental-marking
 
 var source =

test/inspector/runtime/internal-properties-entries.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 
 let {session, contextGroup, Protocol} = InspectorTest.start('Checks internal [[Entries]] in Runtime.getProperties output');
 

test/mjsunit/baseline/flush-baseline-code.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-gc --stress-flush-bytecode --allow-natives-syntax
+// Flags: --expose-gc --stress-flush-code --allow-natives-syntax
 // Flags: --baseline-batch-compilation-threshold=0 --sparkplug
 // Flags: --no-always-sparkplug --lazy-feedback-allocation
 // Flags: --flush-baseline-code

test/mjsunit/check-bounds-array-index.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 //
 // Flags: --allow-natives-syntax --opt --no-always-opt
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 
 let arr = [1, 2, 3];
 

test/mjsunit/check-bounds-string-from-char-code-at.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 //
 // Flags: --allow-natives-syntax --opt --no-always-opt
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 
 let string = "foobar";
 

test/mjsunit/code-coverage-ad-hoc.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-code
 // Files: test/mjsunit/code-coverage-utils.js
 
 // Test code coverage without explicitly activating it upfront.

test/mjsunit/code-coverage-block-async.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-code
 // Flags: --no-stress-incremental-marking
 // Files: test/mjsunit/code-coverage-utils.js
 

test/mjsunit/code-coverage-block-noopt.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-code
 // Flags: --no-opt
 // Files: test/mjsunit/code-coverage-utils.js
 

test/mjsunit/code-coverage-block-opt.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --no-always-opt --opt
-// Flags: --no-stress-flush-bytecode --turbo-inlining
+// Flags: --no-stress-flush-code --turbo-inlining
 // Files: test/mjsunit/code-coverage-utils.js
 
 if (isNeverOptimizeLiteMode()) {

test/mjsunit/code-coverage-block.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-code
 // Files: test/mjsunit/code-coverage-utils.js
 
 %DebugToggleBlockCoverage(true);

test/mjsunit/code-coverage-class-fields.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --no-always-opt --harmony-public-fields
-// Flags: --harmony-static-fields --no-stress-flush-bytecode
+// Flags: --harmony-static-fields --no-stress-flush-code
 // Files: test/mjsunit/code-coverage-utils.js
 
 %DebugToggleBlockCoverage(true);

test/mjsunit/code-coverage-precise.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --no-always-opt --no-stress-flush-code
 // Flags: --no-stress-incremental-marking
 // Files: test/mjsunit/code-coverage-utils.js
 

test/mjsunit/compiler/array-slice-clone.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --opt --no-stress-flush-code
 
 
 // Test CloneFastJSArray inserted by JSCallReducer for Array.prototype.slice.

test/mjsunit/compiler/dataview-deopt.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --opt --no-always-opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --opt --no-always-opt --no-stress-flush-code
 
 // Check that there are no deopt loops for DataView methods.
 

test/mjsunit/compiler/dataview-detached.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --opt --noalways-opt --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --opt --noalways-opt --no-stress-flush-code
 
 // Invalidate the detaching protector.
 %ArrayBufferDetach(new ArrayBuffer(1));

test/mjsunit/compiler/deopt-array-builtins.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --allow-natives-syntax --opt --no-flush-bytecode --no-stress-flush-bytecode
+// Flags: --allow-natives-syntax --opt --no-flush-bytecode --no-stress-flush-code
 
 /* Test MapCheck behavior */
 

test/mjsunit/compiler/dont-flush-code-marked-for-opt.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --opt --allow-natives-syntax --expose-gc --flush-bytecode
-// Flags: --stress-flush-bytecode
+// Flags: --stress-flush-code
 
 function foo(a) {}
 

test/mjsunit/compiler/regress-9137-1.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --opt
-// Flags: --no-flush-bytecode --no-stress-flush-bytecode
+// Flags: --no-flush-bytecode --no-stress-flush-code
 
 function changeMap(obj) {
   obj.blub = 42;

test/mjsunit/compiler/regress-9137-2.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --opt
-// Flags: --no-flush-bytecode --no-stress-flush-bytecode
+// Flags: --no-flush-bytecode --no-stress-flush-code
 
 function changeMap(obj) {
   obj.blub = 42;

test/mjsunit/const-dict-tracking.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 //
 // Flags: --allow-natives-syntax --opt --no-always-opt
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 // Flags: --block-concurrent-recompilation
 // Flags: --no-turbo-concurrent-get-property-access-info
 //

test/mjsunit/constant-folding-2.js

@@ -27,7 +27,7 @@
 
 
 // Flags: --allow-natives-syntax --nostress-opt --opt
-// Flags: --no-stress-flush-bytecode --no-lazy-feedback-allocation
+// Flags: --no-stress-flush-code --no-lazy-feedback-allocation
 
 function test(f, iterations) {
   %PrepareFunctionForOptimization(f);

test/mjsunit/deopt-unlinked.js

@@ -5,7 +5,7 @@
 // Flags: --allow-natives-syntax --opt --no-always-opt
 // The deopt count is stored in the feedback vector which gets cleared when
 // bytecode is flushed, which --gc-interval can cause in stress modes.
-// Flags: --noflush-bytecode --nostress-flush-bytecode
+// Flags: --no-flush-bytecode --no-stress-flush-code
 
 function foo() {};
 %PrepareFunctionForOptimization(foo);

test/mjsunit/harmony/weakrefs/finalizationregistry-scheduled-for-cleanup-multiple-times.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --expose-gc --noincremental-marking
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 
 let cleanup0_call_count = 0;
 let cleanup0_holdings_count = 0;

test/mjsunit/regress/regress-1034449.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --opt --no-always-opt
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 
 function f(len) {
   return new Array(len);

test/mjsunit/regress/regress-crbug-1031479.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --interrupt-budget=200 --stack-size=200 --budget-for-feedback-vector-allocation=100 --expose-gc --stress-flush-bytecode
+// Flags: --interrupt-budget=200 --stack-size=200 --budget-for-feedback-vector-allocation=100 --expose-gc --stress-flush-code
 
 var i = 0;
 function main() {
@@ -30,7 +30,7 @@ function v0() {
    const v21 = Object.defineProperty([].__proto__,"e",{set:v10});
 }
 const v26 = v0();
-// With --stress-flush-bytecode GC flushes the bytecode for v0 and v10
+// With --stress-flush-code GC flushes the bytecode for v0 and v10
 gc();
 assertThrows(v0, TypeError);
 }

test/mjsunit/regress/regress-v8-8799.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-gc --flush-bytecode --stress-flush-bytecode
+// Flags: --expose-gc --flush-bytecode --stress-flush-code
 
 // Ensure tagged template objects are cached even after bytecode flushing.
 var f = (x) => eval`a${x}b`;

test/mjsunit/regress/regress-v8-9656.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --allow-natives-syntax --no-flush-bytecode
-// Flags: --no-stress-flush-bytecode
+// Flags: --no-stress-flush-code
 // Files: test/mjsunit/code-coverage-utils.js
 
 %DebugToggleBlockCoverage(true);

tools/testrunner/standard_runner.py

@@ -57,7 +57,7 @@ GC_STRESS_FLAGS = ['--gc-interval=500', '--stress-compaction',
                    '--concurrent-recompilation-queue-length=64',
                    '--concurrent-recompilation-delay=500',
                    '--concurrent-recompilation',
-                   '--stress-flush-bytecode',
+                   '--stress-flush-code',
                    '--wasm-code-gc', '--stress-wasm-code-gc']
 
 RANDOM_GC_STRESS_FLAGS = ['--random-gc-interval=5000',