Commit 06263182 authored by Clemens Backes's avatar Clemens Backes Committed by V8 LUCI CQ

[wasm] Remove --trace-wasm-ast-* flags

Those flags are old, not commonly used, and redundant. People usually
rely on external tools to disassembly wasm functions or modules.
Also, the name is misleading as Wasm is not an AST (any more).

R=ahaas@chromium.org

Bug: v8:11879
Change-Id: I0f90d142ae4c7c6b7ee6013ea033951aad6bf133
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996194Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75474}
parent 47051ae0
...@@ -7851,10 +7851,6 @@ bool BuildGraphForWasmFunction(wasm::CompilationEnv* env, ...@@ -7851,10 +7851,6 @@ bool BuildGraphForWasmFunction(wasm::CompilationEnv* env,
WasmGraphBuilder::kCalledFromWasm); WasmGraphBuilder::kCalledFromWasm);
builder.LowerInt64(sig); builder.LowerInt64(sig);
if (func_index >= FLAG_trace_wasm_ast_start &&
func_index < FLAG_trace_wasm_ast_end) {
PrintRawWasmCode(allocator, func_body, env->module, wasm::kPrintLocals);
}
return true; return true;
} }
......
...@@ -944,9 +944,6 @@ DEFINE_DEBUG_BOOL(trace_wasm_interpreter, false, ...@@ -944,9 +944,6 @@ DEFINE_DEBUG_BOOL(trace_wasm_interpreter, false,
"trace interpretation of wasm code") "trace interpretation of wasm code")
DEFINE_DEBUG_BOOL(trace_wasm_streaming, false, DEFINE_DEBUG_BOOL(trace_wasm_streaming, false,
"trace streaming compilation of wasm code") "trace streaming compilation of wasm code")
DEFINE_INT(trace_wasm_ast_start, 0,
"start function for wasm AST trace (inclusive)")
DEFINE_INT(trace_wasm_ast_end, 0, "end function for wasm AST trace (exclusive)")
DEFINE_BOOL(liftoff, true, DEFINE_BOOL(liftoff, true,
"enable Liftoff, the baseline compiler for WebAssembly") "enable Liftoff, the baseline compiler for WebAssembly")
DEFINE_BOOL(liftoff_only, false, DEFINE_BOOL(liftoff_only, false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment