Commit 05bcc2fb authored by Benedikt Meurer's avatar Benedikt Meurer

[x86] Blacklist AVX for all Mac OS versions up to 10.9.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/808333005

Cr-Commit-Position: refs/heads/master@{#25969}
parent b2378c74
...@@ -58,8 +58,8 @@ namespace { ...@@ -58,8 +58,8 @@ namespace {
bool EnableAVX() { bool EnableAVX() {
#if V8_OS_MACOSX #if V8_OS_MACOSX
// Mac OS X 10.9 has a bug where AVX transitions were indeed being caused by // Mac OS X up to 10.9 has a bug where AVX transitions were indeed being
// ISRs, so we detect Mac OS X 10.9 here and disable AVX in that case. // caused by ISRs, so we detect that here and disable AVX in that case.
char buffer[128]; char buffer[128];
size_t buffer_size = arraysize(buffer); size_t buffer_size = arraysize(buffer);
int ctl_name[] = { CTL_KERN , KERN_OSRELEASE }; int ctl_name[] = { CTL_KERN , KERN_OSRELEASE };
...@@ -67,9 +67,12 @@ bool EnableAVX() { ...@@ -67,9 +67,12 @@ bool EnableAVX() {
V8_Fatal(__FILE__, __LINE__, "V8 failed to get kernel version"); V8_Fatal(__FILE__, __LINE__, "V8 failed to get kernel version");
} }
// The buffer now contains a string of the form XX.YY.ZZ, where // The buffer now contains a string of the form XX.YY.ZZ, where
// XX is the major kernel version component. 13.x.x (Mavericks) is // XX is the major kernel version component.
// affected by this bug, so disable AVX there. char* period_pos = strchr(buffer, '.');
if (memcmp(buffer, "13.", 3) == 0) return false; DCHECK_NOT_NULL(period_pos);
*period_pos = '\0';
long kernel_version_major = strtol(buffer, nullptr, 10); // NOLINT
if (kernel_version_major <= 13) return false;
#endif // V8_OS_MACOSX #endif // V8_OS_MACOSX
return FLAG_enable_avx; return FLAG_enable_avx;
} }
......
...@@ -24,8 +24,8 @@ namespace { ...@@ -24,8 +24,8 @@ namespace {
bool EnableAVX() { bool EnableAVX() {
#if V8_OS_MACOSX #if V8_OS_MACOSX
// Mac OS X 10.9 has a bug where AVX transitions were indeed being caused by // Mac OS X up to 10.9 has a bug where AVX transitions were indeed being
// ISRs, so we detect Mac OS X 10.9 here and disable AVX in that case. // caused by ISRs, so we detect that here and disable AVX in that case.
char buffer[128]; char buffer[128];
size_t buffer_size = arraysize(buffer); size_t buffer_size = arraysize(buffer);
int ctl_name[] = { CTL_KERN , KERN_OSRELEASE }; int ctl_name[] = { CTL_KERN , KERN_OSRELEASE };
...@@ -33,9 +33,12 @@ bool EnableAVX() { ...@@ -33,9 +33,12 @@ bool EnableAVX() {
V8_Fatal(__FILE__, __LINE__, "V8 failed to get kernel version"); V8_Fatal(__FILE__, __LINE__, "V8 failed to get kernel version");
} }
// The buffer now contains a string of the form XX.YY.ZZ, where // The buffer now contains a string of the form XX.YY.ZZ, where
// XX is the major kernel version component. 13.x.x (Mavericks) is // XX is the major kernel version component.
// affected by this bug, so disable AVX there. char* period_pos = strchr(buffer, '.');
if (memcmp(buffer, "13.", 3) == 0) return false; DCHECK_NOT_NULL(period_pos);
*period_pos = '\0';
long kernel_version_major = strtol(buffer, nullptr, 10); // NOLINT
if (kernel_version_major <= 13) return false;
#endif // V8_OS_MACOSX #endif // V8_OS_MACOSX
return FLAG_enable_avx; return FLAG_enable_avx;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment