Commit 05849031 authored by rossberg's avatar rossberg Committed by Commit bot

[es6] Remove redundant flag parameter

R=adamk@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1286133003

Cr-Commit-Position: refs/heads/master@{#30167}
parent ef52836c
...@@ -1199,8 +1199,7 @@ FunctionLiteral* Parser::ParseLazy(Isolate* isolate, ParseInfo* info, ...@@ -1199,8 +1199,7 @@ FunctionLiteral* Parser::ParseLazy(Isolate* isolate, ParseInfo* info,
if (ok) ok = Check(Token::RPAREN); if (ok) ok = Check(Token::RPAREN);
} else { } else {
// BindingIdentifier // BindingIdentifier
const bool is_rest = false; ParseFormalParameter(&formals, &formals_classifier, &ok);
ParseFormalParameter(is_rest, &formals, &formals_classifier, &ok);
if (ok) { if (ok) {
DeclareFormalParameter( DeclareFormalParameter(
formals.scope, formals.at(0), formals.is_simple, formals.scope, formals.at(0), formals.is_simple,
......
...@@ -700,8 +700,7 @@ class ParserBase : public Traits { ...@@ -700,8 +700,7 @@ class ParserBase : public Traits {
ExpressionT ParseStrongSuperCallExpression(ExpressionClassifier* classifier, ExpressionT ParseStrongSuperCallExpression(ExpressionClassifier* classifier,
bool* ok); bool* ok);
void ParseFormalParameter(bool is_rest, void ParseFormalParameter(FormalParametersT* parameters,
FormalParametersT* parameters,
ExpressionClassifier* classifier, bool* ok); ExpressionClassifier* classifier, bool* ok);
void ParseFormalParameterList(FormalParametersT* parameters, void ParseFormalParameterList(FormalParametersT* parameters,
ExpressionClassifier* classifier, bool* ok); ExpressionClassifier* classifier, bool* ok);
...@@ -2284,9 +2283,8 @@ ParserBase<Traits>::ParsePrimaryExpression(ExpressionClassifier* classifier, ...@@ -2284,9 +2283,8 @@ ParserBase<Traits>::ParsePrimaryExpression(ExpressionClassifier* classifier,
FormalParametersT formals(scope); FormalParametersT formals(scope);
scope->set_start_position(beg_pos); scope->set_start_position(beg_pos);
ExpressionClassifier formals_classifier; ExpressionClassifier formals_classifier;
const bool is_rest = true; formals.has_rest = true;
this->ParseFormalParameter(is_rest, &formals, &formals_classifier, this->ParseFormalParameter(&formals, &formals_classifier, CHECK_OK);
CHECK_OK);
Traits::DeclareFormalParameter( Traits::DeclareFormalParameter(
formals.scope, formals.at(0), formals.is_simple, formals.scope, formals.at(0), formals.is_simple,
&formals_classifier); &formals_classifier);
...@@ -3625,10 +3623,10 @@ ParserBase<Traits>::ParseMemberExpressionContinuation( ...@@ -3625,10 +3623,10 @@ ParserBase<Traits>::ParseMemberExpressionContinuation(
template <class Traits> template <class Traits>
void ParserBase<Traits>::ParseFormalParameter( void ParserBase<Traits>::ParseFormalParameter(
bool is_rest, FormalParametersT* parameters, FormalParametersT* parameters, ExpressionClassifier* classifier, bool* ok) {
ExpressionClassifier* classifier, bool* ok) {
// FormalParameter[Yield,GeneratorParameter] : // FormalParameter[Yield,GeneratorParameter] :
// BindingElement[?Yield, ?GeneratorParameter] // BindingElement[?Yield, ?GeneratorParameter]
bool is_rest = parameters->has_rest;
Token::Value next = peek(); Token::Value next = peek();
ExpressionT pattern = ParsePrimaryExpression(classifier, ok); ExpressionT pattern = ParsePrimaryExpression(classifier, ok);
...@@ -3682,8 +3680,9 @@ void ParserBase<Traits>::ParseFormalParameterList( ...@@ -3682,8 +3680,9 @@ void ParserBase<Traits>::ParseFormalParameterList(
*ok = false; *ok = false;
return; return;
} }
bool is_rest = allow_harmony_rest_parameters() && Check(Token::ELLIPSIS); parameters->has_rest =
ParseFormalParameter(is_rest, parameters, classifier, ok); allow_harmony_rest_parameters() && Check(Token::ELLIPSIS);
ParseFormalParameter(parameters, classifier, ok);
if (!*ok) return; if (!*ok) return;
} while (!parameters->has_rest && Check(Token::COMMA)); } while (!parameters->has_rest && Check(Token::COMMA));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment