Commit 04cdcd5a authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by Commit Bot

[compiler] Move InternalizedString to kNeverSerialized

Bug: v8:7790
Change-Id: I8311b1f4b8239d0688a4b9b9057d6082942bbc00
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534471Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71159}
parent a28eb2c8
...@@ -61,6 +61,8 @@ enum class OddballType : uint8_t { ...@@ -61,6 +61,8 @@ enum class OddballType : uint8_t {
/* Subtypes of FixedArray */ \ /* Subtypes of FixedArray */ \
V(ObjectBoilerplateDescription) \ V(ObjectBoilerplateDescription) \
V(ScopeInfo) \ V(ScopeInfo) \
/* Subtypes of String */ \
V(InternalizedString) \
/* Subtypes of Name */ \ /* Subtypes of Name */ \
V(Symbol) \ V(Symbol) \
/* Subtypes of HeapObject */ \ /* Subtypes of HeapObject */ \
...@@ -92,7 +94,6 @@ enum class OddballType : uint8_t { ...@@ -92,7 +94,6 @@ enum class OddballType : uint8_t {
V(FixedArray) \ V(FixedArray) \
V(FixedDoubleArray) \ V(FixedDoubleArray) \
/* Subtypes of Name */ \ /* Subtypes of Name */ \
V(InternalizedString) \
V(String) \ V(String) \
/* Subtypes of JSReceiver */ \ /* Subtypes of JSReceiver */ \
V(JSObject) \ V(JSObject) \
......
...@@ -870,12 +870,10 @@ StringData::StringData(JSHeapBroker* broker, ObjectData** storage, ...@@ -870,12 +870,10 @@ StringData::StringData(JSHeapBroker* broker, ObjectData** storage,
class InternalizedStringData : public StringData { class InternalizedStringData : public StringData {
public: public:
InternalizedStringData(JSHeapBroker* broker, ObjectData** storage, InternalizedStringData(JSHeapBroker* broker, ObjectData** storage,
Handle<InternalizedString> object); Handle<InternalizedString> object)
: StringData(broker, storage, object) {
uint32_t array_index() const { return array_index_; } DCHECK(!FLAG_turbo_direct_heap_access);
}
private:
uint32_t array_index_;
}; };
ObjectData* StringData::GetCharAsString(JSHeapBroker* broker, uint32_t index, ObjectData* StringData::GetCharAsString(JSHeapBroker* broker, uint32_t index,
...@@ -898,11 +896,6 @@ ObjectData* StringData::GetCharAsString(JSHeapBroker* broker, uint32_t index, ...@@ -898,11 +896,6 @@ ObjectData* StringData::GetCharAsString(JSHeapBroker* broker, uint32_t index,
return result; return result;
} }
InternalizedStringData::InternalizedStringData(
JSHeapBroker* broker, ObjectData** storage,
Handle<InternalizedString> object)
: StringData(broker, storage, object) {}
namespace { namespace {
bool IsFastLiteralHelper(Handle<JSObject> boilerplate, int max_depth, bool IsFastLiteralHelper(Handle<JSObject> boilerplate, int max_depth,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment