Commit 044b76dc authored by Leszek Swirski's avatar Leszek Swirski Committed by V8 LUCI CQ

Revert "[flag] Disable W^X behind --future"

This reverts commit b06f3832.

Reason for revert: Typo in mac arm64 config

Original change's description:
> [flag] Disable W^X behind --future
>
> Measure the impact of W^X on --future bots
>
> Change-Id: I6f60cc835471fa62ec0871101eca5d3022ece519
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168277
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Auto-Submit: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Toon Verwaest <verwaest@chromium.org>
> Reviewed-by: Hannes Payer <hpayer@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76908}

Change-Id: Ia6084a838bc507bc4c988d13d1a991c7604e4653
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3168619
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Owners-Override: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#76909}
parent b06f3832
......@@ -509,7 +509,6 @@ DEFINE_WEAK_IMPLICATION(future, flush_baseline_code)
#if V8_SHORT_BUILTIN_CALLS
DEFINE_WEAK_IMPLICATION(future, short_builtin_calls)
#endif
DEFINE_WEAK_VALUE_IMPLICATION(future, write_protect_code_memory, false)
// Flags for jitless
DEFINE_BOOL(jitless, V8_LITE_BOOL,
......@@ -1181,13 +1180,7 @@ DEFINE_INT(scavenge_task_trigger, 80,
DEFINE_BOOL(scavenge_separate_stack_scanning, false,
"use a separate phase for stack scanning in scavenge")
DEFINE_BOOL(trace_parallel_scavenge, false, "trace parallel scavenge")
#if !defined(V8_OS_MACOSX) || !defined(V8_HOST_ARCH_ARM64)
DEFINE_BOOL(write_protect_code_memory, true, "write protect code memory")
#else
// Must be enabled on M1.
DEFINE_READONLY_BOOL(write_protect_code_memory, true,
"write protect code memory")
#endif
#if defined(V8_ATOMIC_MARKING_STATE) && defined(V8_ATOMIC_OBJECT_FIELD_WRITES)
#define V8_CONCURRENT_MARKING_BOOL true
#else
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment