Commit 03f49567 authored by rmcilroy@chromium.org's avatar rmcilroy@chromium.org

v8_external_snapshot target visible only when using v8_use_external_startup_data

Prevent snapshot_blob.bin from being unnecessarily generated when building all targets.
When such file exists, chrome_tests assumes we will load V8's initial snapshot from
external files, even when such feature is turned off, which prevents the tests from
being successfully compiled.

BUG=421063
LOG=N
R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/643163002

Patch from André Baixo <baixo@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24550 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 3dae2a0d
...@@ -228,6 +228,8 @@ ...@@ -228,6 +228,8 @@
{ {
'target_name': 'v8_external_snapshot', 'target_name': 'v8_external_snapshot',
'type': 'static_library', 'type': 'static_library',
'conditions': [
[ 'v8_use_external_startup_data==1', {
'conditions': [ 'conditions': [
['want_separate_host_toolset==1', { ['want_separate_host_toolset==1', {
'toolsets': ['host', 'target'], 'toolsets': ['host', 'target'],
...@@ -313,6 +315,8 @@ ...@@ -313,6 +315,8 @@
], ],
}, },
], ],
}],
],
}, },
{ {
'target_name': 'v8_base', 'target_name': 'v8_base',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment