Commit 0395c50c authored by mlippautz's avatar mlippautz Committed by Commit bot

Reland of "[platform] Change default platform max thread pool size 4 -> 8"

This reverts commit 4857110c.

This change was flushing out another issue which is fixed in
  https://codereview.chromium.org/1783283003/

BUG=v8:2999
LOG=N

Review URL: https://codereview.chromium.org/1785933003

Cr-Commit-Position: refs/heads/master@{#34874}
parent 87090ee9
...@@ -29,9 +29,7 @@ bool PumpMessageLoop(v8::Platform* platform, v8::Isolate* isolate) { ...@@ -29,9 +29,7 @@ bool PumpMessageLoop(v8::Platform* platform, v8::Isolate* isolate) {
return reinterpret_cast<DefaultPlatform*>(platform)->PumpMessageLoop(isolate); return reinterpret_cast<DefaultPlatform*>(platform)->PumpMessageLoop(isolate);
} }
const int DefaultPlatform::kMaxThreadPoolSize = 8;
const int DefaultPlatform::kMaxThreadPoolSize = 4;
DefaultPlatform::DefaultPlatform() DefaultPlatform::DefaultPlatform()
: initialized_(false), thread_pool_size_(0) {} : initialized_(false), thread_pool_size_(0) {}
...@@ -66,7 +64,7 @@ void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) { ...@@ -66,7 +64,7 @@ void DefaultPlatform::SetThreadPoolSize(int thread_pool_size) {
base::LockGuard<base::Mutex> guard(&lock_); base::LockGuard<base::Mutex> guard(&lock_);
DCHECK(thread_pool_size >= 0); DCHECK(thread_pool_size >= 0);
if (thread_pool_size < 1) { if (thread_pool_size < 1) {
thread_pool_size = base::SysInfo::NumberOfProcessors(); thread_pool_size = base::SysInfo::NumberOfProcessors() - 1;
} }
thread_pool_size_ = thread_pool_size_ =
std::max(std::min(thread_pool_size, kMaxThreadPoolSize), 1); std::max(std::min(thread_pool_size, kMaxThreadPoolSize), 1);
......
...@@ -72,6 +72,7 @@ ...@@ -72,6 +72,7 @@
# BUG(2999). The cpu profiler tests are notoriously flaky. # BUG(2999). The cpu profiler tests are notoriously flaky.
'test-cpu-profiler/CpuProfileDeepStack': [SKIP], 'test-cpu-profiler/CpuProfileDeepStack': [SKIP],
'test-cpu-profiler/CollectCpuProfile': [SKIP],
'test-cpu-profiler/HotDeoptNoFrameEntry': [SKIP], 'test-cpu-profiler/HotDeoptNoFrameEntry': [SKIP],
'test-cpu-profiler/SampleWhenFrameIsNotSetup': [SKIP], 'test-cpu-profiler/SampleWhenFrameIsNotSetup': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment