[cleanup] Refactor interpreter to use default members.

Fixing clang-tidy warning.

Bug: v8:8015
Change-Id: I6cd63aa164af2e3b4a846933899a9a1baa54b1ef
Reviewed-on: https://chromium-review.googlesource.com/1224032Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Florian Sattler <sattlerf@google.com>
Cr-Commit-Position: refs/heads/master@{#55921}

src/interpreter/bytecode-array-builder.cc

@@ -23,7 +23,7 @@ class RegisterTransferWriter final
       public NON_EXPORTED_BASE(ZoneObject) {
  public:
   RegisterTransferWriter(BytecodeArrayBuilder* builder) : builder_(builder) {}
-  ~RegisterTransferWriter() override {}
+  ~RegisterTransferWriter() override = default;
 
   void EmitLdar(Register input) override { builder_->OutputLdarRaw(input); }
 

src/interpreter/bytecode-register-allocator.h

@@ -19,7 +19,7 @@ class BytecodeRegisterAllocator final {
   // Enables observation of register allocation and free events.
   class Observer {
    public:
-    virtual ~Observer() {}
+    virtual ~Observer() = default;
     virtual void RegisterAllocateEvent(Register reg) = 0;
     virtual void RegisterListAllocateEvent(RegisterList reg_list) = 0;
     virtual void RegisterListFreeEvent(RegisterList reg_list) = 0;
@@ -29,7 +29,7 @@ class BytecodeRegisterAllocator final {
       : next_register_index_(start_index),
         max_register_count_(start_index),
         observer_(nullptr) {}
-  ~BytecodeRegisterAllocator() {}
+  ~BytecodeRegisterAllocator() = default;
 
   // Returns a new register.
   Register NewRegister() {

src/interpreter/bytecode-register-optimizer.h

@@ -23,8 +23,8 @@ class V8_EXPORT_PRIVATE BytecodeRegisterOptimizer final
  public:
   class BytecodeWriter {
    public:
-    BytecodeWriter() {}
-    virtual ~BytecodeWriter() {}
+    BytecodeWriter() = default;
+    virtual ~BytecodeWriter() = default;
 
     // Called to emit a register transfer bytecode.
     virtual void EmitLdar(Register input) = 0;
@@ -39,7 +39,7 @@ class V8_EXPORT_PRIVATE BytecodeRegisterOptimizer final
                             BytecodeRegisterAllocator* register_allocator,
                             int fixed_registers_count, int parameter_count,
                             BytecodeWriter* bytecode_writer);
-  virtual ~BytecodeRegisterOptimizer() {}
+  virtual ~BytecodeRegisterOptimizer() = default;
 
   // Perform explicit register transfer operations.
   void DoLdar(Register input) {

src/interpreter/control-flow-builders.h

@@ -20,7 +20,7 @@ class V8_EXPORT_PRIVATE ControlFlowBuilder {
  public:
   explicit ControlFlowBuilder(BytecodeArrayBuilder* builder)
       : builder_(builder) {}
-  virtual ~ControlFlowBuilder() {}
+  virtual ~ControlFlowBuilder() = default;
 
  protected:
   BytecodeArrayBuilder* builder() const { return builder_; }

src/interpreter/interpreter-generator.cc

@@ -1123,7 +1123,7 @@ class UnaryNumericOpAssembler : public InterpreterAssembler {
                           OperandScale operand_scale)
       : InterpreterAssembler(state, bytecode, operand_scale) {}
 
-  virtual ~UnaryNumericOpAssembler() {}
+  virtual ~UnaryNumericOpAssembler() = default;
 
   // Must return a tagged value.
   virtual TNode<Number> SmiOp(TNode<Smi> smi_value, Variable* var_feedback,

src/interpreter/interpreter.h

@@ -36,7 +36,7 @@ class InterpreterAssembler;
 class Interpreter {
  public:
   explicit Interpreter(Isolate* isolate);
-  virtual ~Interpreter() {}
+  virtual ~Interpreter() = default;
 
   // Returns the interrupt budget which should be used for the profiler counter.
   static int InterruptBudget();

test/cctest/interpreter/interpreter-tester.cc

@@ -38,7 +38,7 @@ InterpreterTester::InterpreterTester(Isolate* isolate, const char* source,
     : InterpreterTester(isolate, source, MaybeHandle<BytecodeArray>(),
                         MaybeHandle<FeedbackMetadata>(), filter) {}
 
-InterpreterTester::~InterpreterTester() {}
+InterpreterTester::~InterpreterTester() = default;
 
 Local<Message> InterpreterTester::CheckThrowsReturnMessage() {
   TryCatch try_catch(reinterpret_cast<v8::Isolate*>(isolate_));

test/cctest/interpreter/interpreter-tester.h

@@ -36,7 +36,7 @@ class InterpreterCallable {
  public:
   InterpreterCallable(Isolate* isolate, Handle<JSFunction> function)
       : isolate_(isolate), function_(function) {}
-  virtual ~InterpreterCallable() {}
+  virtual ~InterpreterCallable() = default;
 
   MaybeHandle<Object> operator()(A... args) {
     return CallInterpreter(isolate_, function_, args...);

test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -22,8 +22,8 @@ namespace interpreter {
 
 class BytecodeArrayBuilderTest : public TestWithIsolateAndZone {
  public:
-  BytecodeArrayBuilderTest() {}
-  ~BytecodeArrayBuilderTest() override {}
+  BytecodeArrayBuilderTest() = default;
+  ~BytecodeArrayBuilderTest() override = default;
 };
 
 using ToBooleanMode = BytecodeArrayBuilder::ToBooleanMode;

test/unittests/interpreter/bytecode-array-iterator-unittest.cc

@@ -16,8 +16,8 @@ namespace interpreter {
 
 class BytecodeArrayIteratorTest : public TestWithIsolateAndZone {
  public:
-  BytecodeArrayIteratorTest() {}
-  ~BytecodeArrayIteratorTest() override {}
+  BytecodeArrayIteratorTest() = default;
+  ~BytecodeArrayIteratorTest() override = default;
 };
 
 TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {

test/unittests/interpreter/bytecode-array-random-iterator-unittest.cc

@@ -16,8 +16,8 @@ namespace interpreter {
 
 class BytecodeArrayRandomIteratorTest : public TestWithIsolateAndZone {
  public:
-  BytecodeArrayRandomIteratorTest() {}
-  ~BytecodeArrayRandomIteratorTest() override {}
+  BytecodeArrayRandomIteratorTest() = default;
+  ~BytecodeArrayRandomIteratorTest() override = default;
 };
 
 TEST_F(BytecodeArrayRandomIteratorTest, InvalidBeforeStart) {

test/unittests/interpreter/bytecode-array-writer-unittest.cc

@@ -34,7 +34,7 @@ class BytecodeArrayWriterUnittest : public TestWithIsolateAndZone {
         bytecode_array_writer_(
             zone(), &constant_array_builder_,
             SourcePositionTableBuilder::RECORD_SOURCE_POSITIONS) {}
-  ~BytecodeArrayWriterUnittest() override {}
+  ~BytecodeArrayWriterUnittest() override = default;
 
   void Write(Bytecode bytecode, BytecodeSourceInfo info = BytecodeSourceInfo());
   void Write(Bytecode bytecode, uint32_t operand0,

test/unittests/interpreter/bytecode-register-allocator-unittest.cc

@@ -16,7 +16,7 @@ namespace interpreter {
 class BytecodeRegisterAllocatorTest : public TestWithIsolateAndZone {
  public:
   BytecodeRegisterAllocatorTest() : allocator_(0) {}
-  ~BytecodeRegisterAllocatorTest() override {}
+  ~BytecodeRegisterAllocatorTest() override = default;
 
   BytecodeRegisterAllocator* allocator() { return &allocator_; }
 

test/unittests/interpreter/bytecode-register-optimizer-unittest.cc

@@ -23,7 +23,7 @@ class BytecodeRegisterOptimizerTest
     Register output;
   };
 
-  BytecodeRegisterOptimizerTest() {}
+  BytecodeRegisterOptimizerTest() = default;
   ~BytecodeRegisterOptimizerTest() override { delete register_allocator_; }
 
   void Initialize(int number_of_parameters, int number_of_locals) {

test/unittests/interpreter/constant-array-builder-unittest.cc

@@ -18,8 +18,8 @@ namespace interpreter {
 
 class ConstantArrayBuilderTest : public TestWithIsolateAndZone {
  public:
-  ConstantArrayBuilderTest() {}
-  ~ConstantArrayBuilderTest() override {}
+  ConstantArrayBuilderTest() = default;
+  ~ConstantArrayBuilderTest() override = default;
 
   static const size_t k8BitCapacity = ConstantArrayBuilder::k8BitCapacity;
   static const size_t k16BitCapacity = ConstantArrayBuilder::k16BitCapacity;

test/unittests/interpreter/interpreter-assembler-unittest.h

@@ -28,8 +28,8 @@ class InterpreterAssemblerTestState : public compiler::CodeAssemblerState {
 
 class InterpreterAssemblerTest : public TestWithIsolateAndZone {
  public:
-  InterpreterAssemblerTest() {}
-  ~InterpreterAssemblerTest() override {}
+  InterpreterAssemblerTest() = default;
+  ~InterpreterAssemblerTest() override = default;
 
   class InterpreterAssemblerForTest final : public InterpreterAssembler {
    public: