Commit 0327f8de authored by yangguo's avatar yangguo Committed by Commit bot

Disable stack trace preprocessing.

This has to wait until issue 4065 has been fixed.

R=ulan@chromium.org
BUG=v8:2340, v8:4065, chromium:482312
LOG=N

Review URL: https://codereview.chromium.org/1110393002

Cr-Commit-Position: refs/heads/master@{#28175}
parent ee1b39b4
...@@ -410,11 +410,7 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSObject> error_object, ...@@ -410,11 +410,7 @@ Handle<Object> Isolate::CaptureSimpleStackTrace(Handle<JSObject> error_object,
elements->Shrink(cursor); elements->Shrink(cursor);
Handle<JSArray> result = factory()->NewJSArrayWithElements(elements); Handle<JSArray> result = factory()->NewJSArrayWithElements(elements);
result->set_length(Smi::FromInt(cursor)); result->set_length(Smi::FromInt(cursor));
// Queue this structured stack trace for preprocessing on GC. // TODO(yangguo): Queue this structured stack trace for preprocessing on GC.
Handle<Object> old_weak_list(heap()->weak_stack_trace_list(), this);
Handle<WeakFixedArray> new_weak_list =
WeakFixedArray::Add(old_weak_list, elements);
factory()->set_weak_stack_trace_list(new_weak_list);
return result; return result;
} }
......
...@@ -91,6 +91,9 @@ ...@@ -91,6 +91,9 @@
# Fails sometimes. # Fails sometimes.
'test-debug/ProcessDebugMessagesThreaded': [PASS, FLAKY], 'test-debug/ProcessDebugMessagesThreaded': [PASS, FLAKY],
# BUG(2340). Preprocessing stack traces is disabled at the moment.
'test-heap/PreprocessStackTrace': [FAIL],
############################################################################## ##############################################################################
# TurboFan compiler failures. # TurboFan compiler failures.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment