Commit 031d76a4 authored by Simon Zünd's avatar Simon Zünd Committed by V8 LUCI CQ

[liveedit] Add Myers algorithm diffing implementation

This CL adds a new diffing implementation based on Myers algorithm
to live editing. We straight-up implement the algorithm presented in
"Myers, E.W. An O(ND) difference algorithm and its variations (1986)"
particularly the "Linear space refinement" presented in section 4b.

Note that the CL does not enable the new algorithm straight-away.
We'll land a separate CL for easier revertability.

Myers algorithm is a great improvement over the current dynamic
programming approach. Local benchmarking with a 130kB script
has shown drastic improvements both for time and space:

    Live editing script (Old line count 10236 vs New 10240)
    Dynamic Programming: 65701.931 ms
    Myers:               11.735 ms

Bug: chromium:1205288
Change-Id: I136f176f4a0d3c9a5dcd7a157c72c49c475bea19
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3804860Reviewed-by: 's avatarKim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#82243}
parent 6ca3adb9
This diff is collapsed.
...@@ -34,8 +34,15 @@ class Comparator { ...@@ -34,8 +34,15 @@ class Comparator {
virtual ~Output() = default; virtual ~Output() = default;
}; };
enum class CompareMethod {
kDynamicProgramming,
kMyers,
};
// Finds the difference between 2 arrays of elements. // Finds the difference between 2 arrays of elements.
static void CalculateDifference(Input* input, Output* result_writer); static void CalculateDifference(
Input* input, Output* result_writer,
CompareMethod = CompareMethod::kDynamicProgramming);
}; };
} // namespace internal } // namespace internal
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment