Remove unused return values from PreEdge visitor.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/679093002

Cr-Commit-Position: refs/heads/master@{#24906}
git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@24906 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 86603269
...@@ -118,7 +118,7 @@ class JSONGraphEdgeWriter : public NullNodeVisitor { ...@@ -118,7 +118,7 @@ class JSONGraphEdgeWriter : public NullNodeVisitor {
void Print() { const_cast<Graph*>(graph_)->VisitNodeInputsFromEnd(this); } void Print() { const_cast<Graph*>(graph_)->VisitNodeInputsFromEnd(this); }
GenericGraphVisit::Control PreEdge(Node* from, int index, Node* to); void PreEdge(Node* from, int index, Node* to);
private: private:
std::ostream& os_; std::ostream& os_;
...@@ -129,8 +129,7 @@ class JSONGraphEdgeWriter : public NullNodeVisitor { ...@@ -129,8 +129,7 @@ class JSONGraphEdgeWriter : public NullNodeVisitor {
}; };
GenericGraphVisit::Control JSONGraphEdgeWriter::PreEdge(Node* from, int index, void JSONGraphEdgeWriter::PreEdge(Node* from, int index, Node* to) {
Node* to) {
if (first_edge_) { if (first_edge_) {
first_edge_ = false; first_edge_ = false;
} else { } else {
...@@ -152,7 +151,6 @@ GenericGraphVisit::Control JSONGraphEdgeWriter::PreEdge(Node* from, int index, ...@@ -152,7 +151,6 @@ GenericGraphVisit::Control JSONGraphEdgeWriter::PreEdge(Node* from, int index,
} }
os_ << "{\"source\":" << to->id() << ",\"target\":" << from->id() os_ << "{\"source\":" << to->id() << ",\"target\":" << from->id()
<< ",\"index\":" << index << ",\"type\":\"" << edge_type << "\"}"; << ",\"index\":" << index << ",\"type\":\"" << edge_type << "\"}";
return GenericGraphVisit::CONTINUE;
} }
...@@ -174,7 +172,6 @@ class GraphVisualizer : public NullNodeVisitor { ...@@ -174,7 +172,6 @@ class GraphVisualizer : public NullNodeVisitor {
void Print(); void Print();
GenericGraphVisit::Control Pre(Node* node); GenericGraphVisit::Control Pre(Node* node);
GenericGraphVisit::Control PreEdge(Node* from, int index, Node* to);
private: private:
void AnnotateNode(Node* node); void AnnotateNode(Node* node);
...@@ -221,17 +218,6 @@ GenericGraphVisit::Control GraphVisualizer::Pre(Node* node) { ...@@ -221,17 +218,6 @@ GenericGraphVisit::Control GraphVisualizer::Pre(Node* node) {
} }
GenericGraphVisit::Control GraphVisualizer::PreEdge(Node* from, int index,
Node* to) {
if (use_to_def_) return GenericGraphVisit::CONTINUE;
// When going from def to use, only consider white -> other edges, which are
// the dead nodes that use live nodes. We're probably not interested in
// dead nodes that only use other dead nodes.
if (white_nodes_.count(from) > 0) return GenericGraphVisit::CONTINUE;
return GenericGraphVisit::SKIP;
}
static bool IsLikelyBackEdge(Node* from, int index, Node* to) { static bool IsLikelyBackEdge(Node* from, int index, Node* to) {
if (from->opcode() == IrOpcode::kPhi || if (from->opcode() == IrOpcode::kPhi ||
from->opcode() == IrOpcode::kEffectPhi) { from->opcode() == IrOpcode::kEffectPhi) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment