Commit 027cecdb authored by Pierre Langlois's avatar Pierre Langlois Committed by Commit Bot

[perf-prof] Do not crash on BytecodeArray move events

The logger for perf does not support relocating code objects so as a result we
disable code space compacting to make sure code does not move. However, a
a CodeMove event may still happen if a BytecodeArray object moves, which isn't
relevant to the perf jit support so we can ignore it.

Bug: 
Change-Id: Ie6acf58fe6adfb5cec2f8756f457134cf3b13c2a
Reviewed-on: https://chromium-review.googlesource.com/759795Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
Cr-Commit-Position: refs/heads/master@{#49459}
parent 25820bda
...@@ -377,8 +377,9 @@ void PerfJitLogger::LogWriteUnwindingInfo(Code* code) { ...@@ -377,8 +377,9 @@ void PerfJitLogger::LogWriteUnwindingInfo(Code* code) {
} }
void PerfJitLogger::CodeMoveEvent(AbstractCode* from, Address to) { void PerfJitLogger::CodeMoveEvent(AbstractCode* from, Address to) {
// Code relocation not supported. // We may receive a CodeMove event if a BytecodeArray object moves. Otherwise
UNREACHABLE(); // code relocation is not supported.
CHECK(from->IsBytecodeArray());
} }
void PerfJitLogger::LogWriteBytes(const char* bytes, int size) { void PerfJitLogger::LogWriteBytes(const char* bytes, int size) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment