• bmeurer@chromium.org's avatar
    Improve implementation of HSeqStringSetChar. · 980739a2
    bmeurer@chromium.org authored
    This improves the generated code for HSeqStringSetChar across
    all platforms, taking advantage of constant operands whenever
    possible. It also drops the unused DefineSameAsFirst constraint
    for the register allocator on x64 and ia32, where it caused
    unnecessary spills when the string operand was live across the
    HSeqStringSetChar instruction.
    
    A new GVN flag StringChars is introduced to express dependencies
    between HSeqStringSetChar, HStringCharCodeAt and the upcoming
    HSeqStringGetChar (the GVNFlags type is now 64bit in size).
    
    Also improves the test case.
    
    TEST=mjsunit/string-natives
    R=mstarzinger@chromium.org, yangguo@chromium.org
    
    Review URL: https://codereview.chromium.org/57383004
    
    git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17521 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    980739a2
string-natives.js 3.01 KB