• bakkot's avatar
    Sloppy-mode function declarations in blocks are now hoisted appropriately. · 9bbba144
    bakkot authored
    In ES2016, function declarations nested in blocks are formally allowed. This was
    never a part of ECMAScript, but was a common extension. Unfortunately
    implementations differed in the exact semantics. Annex B.3.3 in the spec tries
    to standardize the parts which are common to different implementations, but does
    so with some fairly complicated semantics.
    
    This CL addresses three issues related to annex B.3.3:
    * When the outer function had a complex parameter list, no hoisting whatsoever was
      being performed.
    * Hoisting was not blocked by parameters of the same name.
    * Hoisting was not blocked by nested lexical declarations of the same name.
    
    We had tests which checked for the second, but they were incorrectly passing due to
    the first. This CL adds more complete tests.
    
    BUG=v8:5151, v8:5111
    
    Review-Url: https://codereview.chromium.org/2099623003
    Cr-Commit-Position: refs/heads/master@{#37405}
    9bbba144
parser.cc 261 KB