• Sathya Gunasekaran's avatar
    [WeakRefs] Make cleanup callback run as a task · 743ce772
    Sathya Gunasekaran authored
    Previously, this was run as a microtask and this CL changes it to run
    as a separate task as mandated by the current WeakRef spec.
    
    This CL also introduces a FinalizationGroup type to the V8 API
    representing the JSFinalizationGroup. This has a `Cleanup`
    function that runs the cleanup callback associated with it.
    
    SetHostCleanupFinalizationGroupCallback is added to set
    the embedder defined HostCleanupFinalizationGroupCallback.
    
    ClearKeptObject is exposed on the v8::Isolate to reset the strongly
    held set of objects.
    
    The general workflow is the following:
    
    (a) When the GC notices that a given finalization group has dirty
        cells, it calls HostCleanupFinalizationGroupCallback with the given
        finalization group.
    
    (b) As part of HostCleanupFinalizationGroupCallback, the embedder
        enqueues a task that at some point later calls
        FinalizationGroup::Cleanup.
    
    (c) At some point in the future, FinalizationGroup::Cleanup is called,
        which runs the cleanup callback of the finalization group.
    
    This patch also includes d8 changes to use these new APIs. Currently,
    d8 cycles through the enqueued finalization groups after a synchronous
    turn (and it's microtask checkpoint) and runs the cleanup callbacks.
    
    Change-Id: I06eb4da2c103b2792a9c62bc4b98fd4e5c4892fc
    Bug: v8:8179
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1655655
    Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarHannes Payer <hpayer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62984}
    743ce772
weakref-creation-keeps-alive.js 659 Bytes