• Clemens Hammacher's avatar
    Reland "[test] Check for illegal uses of mjsunit methods" · ac73e1d5
    Clemens Hammacher authored
    This is a reland of a9e93572
    
    Original change's description:
    > [test] Check for illegal uses of mjsunit methods
    > 
    > The assertThrows and assertDoesNotThrow methods expect either a
    > function to execute, or a string to eval. In several tests however we
    > accidentally passed the *result* of the statement to be tested instead
    > of the code.
    > This CL adds check to catch such error early, and removes wrong uses.
    > In most places, we do not need to use assertDoesNotThrow anyway,
    > because exceptions are handled as test failures.
    > 
    > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
    > MjsUnitAssertionErrors correctly.
    > 
    > R=mathias@chromium.org
    > 
    > Bug: v8:8562
    > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
    > Reviewed-on: https://chromium-review.googlesource.com/c/1439238
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59277}
    
    Bug: v8:8562
    Change-Id: I3b26935f7b35302d499266155273ea271bf8151d
    Reviewed-on: https://chromium-review.googlesource.com/c/1449792Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59328}
    ac73e1d5
errors.js 6.05 KB