• Clemens Hammacher's avatar
    Revert "Reland "[GC] Ensure JSFunctions with flushed bytecode are flushed during GC."" · 1a95d4de
    Clemens Hammacher authored
    This reverts commit d5e63b03.
    
    Reason for revert: Fails gc-stress: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/5312
    
    Original change's description:
    > Reland "[GC] Ensure JSFunctions with flushed bytecode are flushed during GC."
    > 
    > This is a reland of f5729f1c
    > 
    > TBR=ulan@chromium.org
    > 
    > Original change's description:
    > > [GC] Ensure JSFunctions with flushed bytecode are flushed during GC.
    > >
    > > When bytecode is flushed from a SFI, the JSFunctions still retain their
    > > FeedbackVector's and point to the interpreter entry trampoline. They are
    > > reset if re-executed, however if not they could hold onto the feedback
    > > vector indefinetly. This CL adds a pass the GC to detect JSFunctions that
    > > need to be reset, and performs the reset at the end of GC.
    > >
    > > BUG=v8:8395
    > >
    > > Change-Id: I3de8655aff9ff80f912b4fd51dee43eb98cfd519
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1393292
    > > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#58775}
    > 
    > Bug: v8:8395
    > Change-Id: I9bc84b62332575a080561c51f08b699b91e41e4a
    > Reviewed-on: https://chromium-review.googlesource.com/c/1414859
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58924}
    
    TBR=ulan@chromium.org,rmcilroy@chromium.org
    
    Change-Id: I5d3012d4c7277ae792b0488780ff426d51dd602f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8395
    Reviewed-on: https://chromium-review.googlesource.com/c/1421838Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58925}
    1a95d4de
objects-visiting.h 7.51 KB