• Maya Lekova's avatar
    [turbofan] Introduce a CheckStringAdd node instead of cons string lowering · 6a7872b7
    Maya Lekova authored
    The new node is introduced for literal string addition and calling
    String.prototype.concat in the typed lowering phase. It later might get optimized
    away during redundancy elimination, keeping the performance of already existing
    benchmarks with string addition. In case the operation is about to throw
    (due to too long string being constructed) we just deoptimize, reusing
    the interpreter logic for creating the error.
    
    Modify relevant mjsunit and unit tests for string concatenation.
    
    Bug: v8:7902
    Change-Id: Ie97d39534df4480fa8d4fe3ba276d02ed5e750e3
    Reviewed-on: https://chromium-review.googlesource.com/1193342
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55482}
    6a7872b7
string-add-try-catch.js 1.63 KB