• Clemens Backes's avatar
    [wasm][debug] Do not install debug code when tiered up · dc318df3
    Clemens Backes authored
    If the debugger is disabled for an isolate, we first remove all
    breakpoints for that isolate, and then tier up the module (if there is
    no other isolate that keeps it tiered down).
    During the first step, functions might get recompiled since the
    set breakpoints change. This is not needed in case we will tier-up the
    module afterwards anyway. It also triggers a DCHECK if we reinstall
    debugging code even though the module is already marked "tiered up".
    
    This CL avoids the installation of debugging if the module is not tiered
    down, and also slightly modified the condition for installing new code
    when tiered-up (to allow overwriting debugging code with non-debugging
    code even if it's the same tier).
    
    R=thibaudm@chromium.org
    
    Bug: chromium:1228628
    Change-Id: I83828d4186e299f779a858006eafa3dbc7966c35
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3026707Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75722}
    dc318df3
wasm-code-manager.cc 95.4 KB