Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
V
V8
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • V8
  • Repository

Switch branch/tag
  • v8
  • test
  • mjsunit
  • temporal
  • instant-constructor.js
Find file
BlameHistoryPermalink
  • Frank Tang's avatar
    [Temporal] Fix test to sync with latest spec after spec change. · 6fd50360
    Frank Tang authored Aug 03, 2022
    1. fix year value between 100 and 9999 should use 4 digit padding without '+' prefix to sync with the latest spec in
    mjsunit/temporal/plain-date-time-to-json
    
    2. Change the the toPlainDateTime to accept object with partial time fields to sync with current spect in
    test/mjsunit/temporal/plain-date-to-plain-date-time.js
    
    3. Change the test to accept input parameter type to Number instead of BigInt for Instant fromEpochSeconds and from EpochMilliseconds in
    test/mjsunit/temporal/instant-from-epoch-milliseconds.js and
    test/mjsunit/temporal/instant-from-epoch-seconds.js
    Throw TypeError if the type is BigInt.
    
    4. Change the return type of Instant epochSeconds and epochMilliseconds from BigInt to Number to sync with the spec in
    test/mjsunit/temporal/instant-constructor.js
    
    Spec text
    https://tc39.es/proposal-temporal/#sec-temporal-padisoyear
    https://tc39.es/proposal-temporal/#sec-temporal-totemporaltimerecord
    https://tc39.es/proposal-temporal/#sec-temporal.instant.fromepochmilliseconds
    https://tc39.es/proposal-temporal/#sec-temporal.instant.fromepochseconds
    https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.epochmilliseconds
    https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.epochseconds
    
    Bug: v8:11544
    Change-Id: Icd290905b65fdabbedece27e59c785635c212ec2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3807122Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82185}
    6fd50360
instant-constructor.js 1.97 KB
EditWeb IDE

Replace instant-constructor.js

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.