Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
V
V8
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • V8
  • Repository

Switch branch/tag
  • v8
  • test
  • mjsunit
  • es6
  • computed-property-names-super.js
Find file
BlameHistoryPermalink
  • Marja Hölttä's avatar
    Reland2 [super] Store home object in Context instead of JSFunction · 31d2bb86
    Marja Hölttä authored Jan 29, 2021
    Fix 1: Track Scope::needs_home_object and Scope::uses_super_property
    accurately. When "eval" is seen, figure out whether it can access
    "super" and if yes, set the corresponding home object as needed.
    
    Fix 2: The object literal scope shouldn't be entered for things
    inside spreads.
    
    Original: https://chromium-review.googlesource.com/c/v8/v8/+/2563275
    Previous reland: https://chromium-review.googlesource.com/c/v8/v8/+/2637220
    
    This saves memory (the home object doesn't need to be stored for each
    method, but only once per class) and hopefully makes the home object
    a constant in the optimized code.
    
    Detailed documentation of the changes:
    https://docs.google.com/document/d/1ZVXcoQdf9IdMsnRI9iyUjyq9NDoEyx9nA3XqMgwflMs/edit?usp=sharing
    
    Bug: v8:9237
    Bug: chromium:1167918
    Bug: chromium:1167981
    Bug: chromium:1167988
    Bug: chromium:1168055
    Bug: chromium:1171195
    Bug: chromium:1171600
    Change-Id: I9686e0d90cd0c1128757eca440a88748897ee91e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2655509
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72422}
    31d2bb86
computed-property-names-super.js 1.7 KB
EditWeb IDE

Replace computed-property-names-super.js

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.