Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
V
V8
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • V8
  • Repository

Switch branch/tag
  • v8
  • test
  • message
  • fail
  • call-expression.js
Find file
BlameHistoryPermalink
  • Sathya Gunasekaran's avatar
    [ignition] Set correct expression position for ObjectLiteral keys/values · acae2f2b
    Sathya Gunasekaran authored Mar 15, 2018
    Given the following input,
      const config = {
        min: Math.min(1, 2),
        func: myfunc(),
      }
    
    Previously, the error was,
      ➜ ./out.gn/x64.release/d8 _test.js
      _test.js:3: ReferenceError: myfunc is not defined
        min: Math.min(1, 2),
                  ^
      ReferenceError: myfunc is not defined
          at _test.js:3:13
    
    Now, the error is,
      ➜ ./out.gn/x64.release/d8 _test.js
      _test.js:4: ReferenceError: myfunc is not defined
        func: myfunc(),
              ^
      ReferenceError: myfunc is not defined
          at _test.js:4:9
    
    Bug: v8:7507
    Change-Id: Ia65b445fdbc1369ecce80f4fc2040e500c807d40
    Reviewed-on: https://chromium-review.googlesource.com/964182Reviewed-by: 's avatarMathias Bynens <mathias@chromium.org>
    Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51964}
    acae2f2b
call-expression.js 229 Bytes
EditWeb IDE

Replace call-expression.js

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.