Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
V
V8
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • V8
  • Repository

Switch branch/tag
  • v8
  • test
  • inspector
  • runtime
  • evaluate-repl-mode.js
Find file
BlameHistoryPermalink
  • Simon Zünd's avatar
    REPL mode must only re-write AST on successful parses · e99d4e77
    Simon Zünd authored Jan 28, 2020
    This CL fixes a parser crash in REPL mode. Some SyntaxErrors can cause
    the AST to contain NULL nodes, resulting in a crash when we want to
    rewrite the AST after parsing.
    
    Instead of re-writing a broken AST we bail early.
    
    R=leszeks@chromium.org
    
    Bug: chromium:1040034, chromium:1045758
    Change-Id: I9c559f6de5969c8db17833ccbdb1608627b46311
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2023547Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66008}
    e99d4e77
evaluate-repl-mode.js 823 Bytes
EditWeb IDE

Replace evaluate-repl-mode.js

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.