Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Contribute to GitLab
  • Sign in / Register
V
V8
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Linshizhi
  • V8
  • Repository

Switch branch/tag
  • v8
  • test
  • debugger
  • debug
  • debug-clearbreakpoint.js
Find file
BlameHistoryPermalink
  • jgruber's avatar
    [tests] Fix assertFalse(exception) anti-pattern · b8ae2249
    jgruber authored Mar 21, 2018
    Some debugging tests relied on the following anti-pattern:
    
     let exception = false;
    
     try {
       /* ... some code that may throw on test failure ... */
     } catch (e) {
       exception = e;
     }
    
     assertFalse(exception);
    
    This may be problematic if a falseish value is thrown.
    
    Change-Id: I02eace4cc656fc9581928a90ac53cda4dc72b30c
    Reviewed-on: https://chromium-review.googlesource.com/972822Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52105}
    b8ae2249
debug-clearbreakpoint.js 2.37 KB
EditWeb IDE

Replace debug-clearbreakpoint.js

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.