• Mythri A's avatar
    Evict deoptimized code on feedback vector after creating the closure · 85b1d24b
    Mythri A authored
    When creating a new closure, we check feedback vector for any optimized
    code and install it on the newly created closure. We evict the optimized
    code from the feedback vector if it is marked for deoptimization. We
    used to evict the code before creating the new closure. However,
    creating a new closure could cause allocation failures and hence trigger
    a GC. This could mark optimized code on feedback vector for
    deoptimization if any weak objects held by optimized code are GC'ed.
    
    This cl delays the eviction unitl after the closure was created.
    
    Bug: v8:1163184
    Change-Id: I217279e4a51f75b87bb7ae5a00fd1cf57805e3c8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2613034
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71999}
    85b1d24b
factory.cc 139 KB