• Qifan Pan's avatar
    Reland "[turbofan] Rematerialize BigInt64 in deopt" · 98c6c367
    Qifan Pan authored
    This is a reland of commit 80fb2815
    
    This CL fixes the signedness of rematerialized Numbers from immediates, which was introduced by the original change. Besides, BigInt truncation to zero bits is lowered to Int64Constant instead of NumberConstant of zero, which will flow into the state values directly.
    
    Original change's description:
    > [turbofan] Rematerialize BigInt64 in deopt
    >
    > This CL introduces two MachineTypes - SignedBigInt64 and UnsignedBigInt64, which are represented as Word64 but will be rematerialized to BigInt in deoptimization. This will avoid unnecessary conversions for BigInt64s when they are passed to StateValues.
    >
    > Bug: v8:9407
    > Change-Id: I65fdee3e028ed8f9920b1c20ff78993c7784de48
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3858238
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Commit-Queue: Qifan Pan <panq@google.com>
    > Cr-Commit-Position: refs/heads/main@{#83230}
    
    Bug: v8:9407, chromium:1364319, chromium:1364400
    Change-Id: I0b4e077b52f64af46018b6c045893bbd56153f32
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899258
    Commit-Queue: Qifan Pan <panq@google.com>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83384}
    98c6c367
code-generator.cc 51 KB