• Ben Smith's avatar
    Reland "[wasm] Implement table.init for interpreter" · 9010424f
    Ben Smith authored
    This is a reland of 63608968
    
    The previous CL failed on Windows, but it was a general bug. The
    dropped_elem_segments was not being set on the instance properly in
    cctests, so`table.init` instructions would fail by reading uninitialized
    data.
    
    I took this opportunity to also add an implementation of
    `elem.drop` in the interpreter, and ported the JS tests for those too.
    
    Original change's description:
    > [wasm] Implement table.init for interpreter
    >
    > This also fixes CheckCallViaJS when a trap occurs. In that case, the
    > trap callback is called instead of an exception being thrown, so if it
    > isn't handled, a bogus result will be returned instead.
    >
    > Bug: v8:8965
    > Change-Id: I560e89f353756df23c062fb8c9484d9971c19253
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539078
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Commit-Queue: Ben Smith <binji@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60473}
    
    Bug: v8:8965
    Change-Id: Ia547d9530b7ca67fde5bd94539f49153b796e82d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547142
    Commit-Queue: Ben Smith <binji@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60664}
    9010424f
wasm-run-utils.h 20.2 KB