• Ng Zhi An's avatar
    Reland "[liftoff] Check fp_pair when looking up register for reuse" · 0d0d38fe
    Ng Zhi An authored
    This is a reland of 548fda4a
    
    regress-1054466 is modified to not use 64x2 operations, since that was
    causing problems on noavx/nosse builds, which requires scalar lowering,
    and scalar lowering for 64x2 ops is not implemented.
    
    Original change's description:
    > [liftoff] Check fp_pair when looking up register for reuse
    >
    > Given two registers that are both not gp_pair, one could be an fp_pair,
    > and the other not, and we will incorrect call == on them. The current
    > check needs to be expanded to check that both registers are fp_pair.
    >
    > Bug: chromium:1054466
    > Change-Id: Ib986c002a8a5cadb9668458597a797cecfd971b1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2070006
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#66402}
    
    Bug: chromium:1054466
    Change-Id: If88f1ff2fb17aaa3727758cda5b368be1c6d9bd6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2071396Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66423}
    0d0d38fe
regress-1054466.js 1.75 KB