• Simon Zünd's avatar
    Reland "[torque] Throw exception instead of aborting if something goes wrong" · 251d1623
    Simon Zünd authored
    This is a reland of 3bd49f9b
    
    The issue on the windows bot is apparently a compiler bug in MSVC related to
    move construction. The fix seems to be to change the order of the fields in
    "JsonParseResult" (go figure).
    
    Drive-by-change: Fix LS on windows by emitting correct line endings and
    enabling exceptions for the LS executable as well.
    
    Original change's description:
    > [torque] Throw exception instead of aborting if something goes wrong
    >
    > This CL enables exceptions for the Torque compiler and Torque language
    > server. Instead of aborting when something goes wrong during
    > compilation, a TorqueError is thrown, containing the error message
    > and a source position. The compiler executable still prints the error
    > and aborts, while the language server will pass this information
    > along to the client (not included in this CL).
    >
    > R=danno@chromium.org
    >
    > Bug: v8:8880
    > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003
    > Reviewed-by: Daniel Clifford <danno@chromium.org>
    > Commit-Queue: Simon Zünd <szuend@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60512}
    
    Bug: v8:8880
    Change-Id: I00e6591bbb4c516dd7540a7e27196853bc637f11
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545995Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60736}
    251d1623
torque-compiler.cc 3.86 KB