• Manos Koukoutos's avatar
    Reland "Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"" · 85a5e208
    Manos Koukoutos authored
    This is a reland of 916eb869
    
    Change compared to original:
    Remove ternary operator from lambda, as this triggers a gcc bug.
    
    Original change's description:
    > Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"
    >
    > This is a reland of 4a037f87
    >
    > Changes compared to original change: None. This seems not to create
    > problems after all.
    >
    > Original change's description:
    > > [wasm][bug] Fix a couple of bugs in validation of unreachable code
    > >
    > > Changes:
    > > - SetBlockType now instantiates the block's start merge with values of
    > >   the correct type in unreachable code.
    > > - EnsureStackArguments now keeps the existing stack values and moves
    > >   them over the new bottom values.
    > > - Drop stack size validation in Drop().
    > > - Add new tests in unreachable-validation.js.
    > >
    > > Change-Id: Ie68b3d9abb0a41d1623d4a123fb526e71941c4e7
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902733
    > > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#74650}
    >
    > Change-Id: Id620f7fb6677b772b0dcfd38108256384db44439
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905598
    > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74677}
    
    Bug: v8:11819
    Change-Id: I9b8d915547ec9aee7cb5233937089d431db54c8f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919833
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74797}
    85a5e208
unreachable-validation.js 6.59 KB