• Adam Klein's avatar
    [parser] Skipping inner funcs: accurately record NeedsHomeObject · 94a71d7c
    Adam Klein authored
    Inner functions which called eval, and were the kind of functions
    that can use `super`, were erroneously not marked as "uses_super_property",
    leading to downstream crashes when the runtime tried to load the
    [[HomeObject]] from them.
    
    This patch eliminates the public Scope::uses_super_property()
    API and ensures that callers always call Scope::NeedsHomeObject()
    instead.
    
    This is a minimal fix designed for easy merging; it's likely that
    in the long run we should remove most mentions of "uses super property"
    and replace them with "needs home object" for clarity.
    
    Bug: v8:5516, chromium:774994
    Change-Id: Id269dd33e35bd40f6b59a3d3e19330687afa64f8
    Reviewed-on: https://chromium-review.googlesource.com/721879Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48619}
    94a71d7c
preparsed-scope-data.cc 20.1 KB