• littledan's avatar
    Ensure CreateDataProperty works correctly on TypedArrays · 7a38462e
    littledan authored
    Previously, CreateDataProperty would fail a DCHECK when used to create
    an integer indexed property on a TypedArray. This patch makes it throw
    a TypeError instead. The issue came up when Array.prototype.concat
    was repaired to use CreateDataProperty rather than SetElement; concat
    can be tricked into making a new TypedArray if it is given an Array
    whose prototype is a TypedArray. This patch prevents the issue.
    
    R=adamk
    LOG=Y
    BUG=chromium:596394
    
    Review URL: https://codereview.chromium.org/1821723004
    
    Cr-Commit-Position: refs/heads/master@{#35271}
    7a38462e
objects.cc 706 KB