• gdeepti's avatar
    [wasm] Fix test-run-wasm-module tests in debug mode. · dd3b14b7
    gdeepti authored
    test-run-wasm-module cctests broken in debug since recent refactoring changes for moving Compilation/Instantiation off the module object (https://codereview.chromium.org/2320723005). The problem here is that SetupIsolateForWasm tries to add the same property to a module_object multiple times and hits a DCHECK when this property is found on a lookup.
     - Fixed to use the setup method only once when CcTest::InitIsolateOnce is used.
     - Move setup method to test as this is only used for cctests/fuzzers. The install method should take care of this in the regular JS pipeline.
    
     R=mtrofin@chromium.org, ahaas@chromium.org
    
    Review-Url: https://codereview.chromium.org/2342263002
    Cr-Commit-Position: refs/heads/master@{#39484}
    dd3b14b7
wasm-js.cc 16 KB