• littledan's avatar
    Make Promise.all/Promise.race catch prediction conditional on DevTools · 37735851
    littledan authored
    To improve performance, this patch makes Promise.all and Promise.race not
    perform correct catch prediction when the debugger is not open. The case
    may come up if Promise.race or Promise.all is called, then DevTools is
    open, then a component Promise is rejected. In this case, the user would
    falsely get an exception event even if the "pause on caught exceptions"
    box is unchecked. There are tests which triggered this case; however, it
    seems both unlikely and and acceptable to have an event in this case.
    Many analogous events are already produced when DevTools is enabled
    during the operation of a program.
    
    BUG=v8:3093
    
    Review-Url: https://codereview.chromium.org/2350363002
    Cr-Commit-Position: refs/heads/master@{#39565}
    37735851
promise-all-uncaught.js 1.88 KB