• Daniel Bevenius's avatar
    [torque] Use char newline character instead of string · 32b22fe9
    Daniel Bevenius authored
    Currently, when GeneratePrintDefinitionsForClass generates its Print
    functions it uses a string literal as the newline character for all the
    last lines. For example:
    
    void TorqueGeneratedStruct<Struct, HeapObject>::StructPrint(
        std::ostream& os) {
      this->PrintHeader(os, "TorqueGeneratedStruct");
      os << "\n";
    }
    
    The last line could use a single character instead of a string,
    for example:
    
    void TorqueGeneratedStruct<Struct, HeapObject>::StructPrint(
        std::ostream& os) {
      this->PrintHeader(os, "TorqueGeneratedStruct");
      os << '\n';
    }
    
    The commit suggests changing this into a char.
    
    Change-Id: Id7a2f5fb17108fcbb543109d18b6b474ac1c5d2d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2108546Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66788}
    32b22fe9
implementation-visitor.cc 179 KB