• Matthias Liedtke's avatar
    [mjsunit] assertEquals: Assert equality of non-enumerable properties too · 319af35d
    Matthias Liedtke authored
    assertEquals() compares objects by comparing each property for both
    objects. This was done by using Object.keys() which however only returns
    enumerable properties.
    With this change also non-enumerable properties are compared.
    
    Still, the comparison doesn't require the properties to be equal.
    So, if one property is marked enumerable in one object but not the
    other, the objects would still be considered equal.
    This could be adapted in a follow-up CL if desired.
    The prototype is still ignored for the comparison.
    
    Change-Id: I1bb9df055bfb764ac1c02d971ac6f4a50f4a98e8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3876384
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83058}
    319af35d
collection-iterator.js 7.26 KB