• Toon Verwaest's avatar
    Revert "[runtime] Cache prototype chain enumerable keys in PrototypeInfo" · 21ad38ef
    Toon Verwaest authored
    This reverts commit 5253d7bf.
    
    Reason for revert: Elements don't properly invalidate the cache.
    
    Original change's description:
    > [runtime] Cache prototype chain enumerable keys in PrototypeInfo
    > 
    > This CL adds a prototype_chain_enum_cache to cache the enumeration of a
    > prototype and its entire chain on the PrototypeInfo. It can improve for-in
    > performance via simply merging the receiver enumeration with this cache.
    > 
    > It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook.
    > 
    > Contributed by tao.pan@intel.com
    > 
    > Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844
    > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65224}
    
    TBR=verwaest@chromium.org,shiyu.zhang@intel.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: Ic5d476bc8b334241b2accb8344749fcf7dcf5e09
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1943153Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Auto-Submit: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65259}
    21ad38ef
for-in-special-cases.js 4.21 KB