• titzer's avatar
    Revert of [turbofan] Take the immediate size in account when narrowing... · 3b7ff999
    titzer authored
    Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ )
    
    Reason for revert:
    Breaks WASM; please also add tests when relanding.
    
    Original issue's description:
    > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators.
    >
    > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter.
    >
    > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4
    > Cr-Commit-Position: refs/heads/master@{#36009}
    
    TBR=bmeurer@chromium.org,jfb@chromium.org,epertoso@chromium.org
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    
    Review-Url: https://codereview.chromium.org/1959603002
    Cr-Commit-Position: refs/heads/master@{#36066}
    3b7ff999
instruction-selector-ia32.cc 54.2 KB