• Ulan Degenbaev's avatar
    [inspector] Fix handling of on-heap TypedArrays in queryObjects() · 5ee9cf87
    Ulan Degenbaev authored
    On-heap TypedArrays have empty ArrayBuffers that are not supposed to be
    accessed directly. Such ArrayBuffers materialize properly when accessed
    via their TypedArrays.
    
    The queryObjects() sidesteps the bottleneck and finds empty ArrayBuffers
    by iterating the heap. When preview TypedArrays are constructed for the
    found ArrayBuffers, they get nullptr data pointers.
    
    This CL converts all on-heap TypedArrays into off-heap TypedArrays in
    queryObjects to make sure that all found ArrayBuffers are valid.
    
    Bug: chromium:992442
    Change-Id: Ie77d1e75aa2007b4a976c72206b9a4e215c9ef53
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2150601
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67174}
    5ee9cf87
query-objects.js 8.45 KB