• Benedikt Meurer's avatar
    [inspector] Correct location for inline scripts with sourceURL. · a81e8d16
    Benedikt Meurer authored
    Previously the `Debugger.CallFrame`s in `Debugger.paused` events would
    report locations relative to the surrounding document in case of inline
    scripts with `//@ sourceURL` annotations (while `Runtime.CallFrame` was
    already fixed previously as part of crrev.com/c/3069289). With this CL
    the locations in `Debugger.CallFrame` are also appropriately adjusted.
    
    Drive-by-fix: Several inspector tests were (incorrectly) relying on this
    wrong treatment, and were also unnecessarily using //# sourceURL
    annotations. So part of this CL also addresses that problem and makes
    the tests more robust, using addInlineScript() helper.
    
    Fixed: chromium:1283049
    Bug: chromium:1183990, chromium:578269
    Change-Id: I6e3b215d951c3453c0a9cfc9bccf3dc3d5e92fd6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3359619
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78450}
    a81e8d16
debugger-stepping-and-breakpoints.js 8.42 KB