• hablich's avatar
    Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the... · db47a31f
    hablich authored
    Revert of [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a … (patchset #3 id:80001 of https://codereview.chromium.org/1642223003/ )
    
    Reason for revert:
    Fails a lot of layout tests and blocks the roll. Can be easily reproduced with a local Chromium checkout.
    
    Reference: https://codereview.chromium.org/1652413003/
    
    Original issue's description:
    > [api] Make ObjectTemplate::SetNativeDataProperty() work even if the ObjectTemplate does not have a constructor.
    >
    > Previously ObjectTemplate::New() logic relied on the fact that all the accessor properties are already installed in the initial map of the function object of the constructor FunctionTemplate.
    > When the FunctionTemplate were instantiated the accessors of the instance templates from the whole inheritance chain were accumulated and added to the initial map.
    > ObjectTemplate::SetSetAccessor() used to explicitly ensure that the ObjectTemplate has a constructor and therefore an initial map to add all accessors to.
    >
    > The new approach is to add all the accessors and data properties to the object exactly when the ObjectTemplate is instantiated. In order to keep it fast we now cache the object boilerplates in the Isolate::template_instantiations_cache (the former function_cache), so the object creation turns to be a deep copying of the boilerplate object.
    >
    > This CL also prohibits non-primitive properties in ObjectTemplate to avoid potential cross-context leaks.
    >
    > BUG=chromium:579009
    > LOG=Y
    >
    > Committed: https://crrev.com/6a118774244d087b5979e9291d628a994f21d59d
    > Cr-Commit-Position: refs/heads/master@{#33674}
    
    TBR=verwaest@chromium.org,ishell@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:579009
    
    Review URL: https://codereview.chromium.org/1660263003
    
    Cr-Commit-Position: refs/heads/master@{#33698}
    db47a31f
conversions.h 6.06 KB