• Seth Brenith's avatar
    Build ScopeInfo in the right order for web snapshots · e553a440
    Seth Brenith authored
    Currently, WebSnapshotDeserializer::CreateScopeInfo creates the
    ScopeInfo first, and then creates its local names hashtable if
    necessary. If GC occurs when creating the local names hashtable, the
    object verifier correctly complains that the ScopeInfo doesn't have all
    needed fields. The solution (consistent with ScopeInfo::Create) is to
    create the local names hashtable first. That way, no GC can happen in
    the interval after the ScopeInfo is allocated but before it has valid
    fields.
    
    Bug: v8:13135
    Change-Id: Ifd6eb10e54a4151f7edb592bc19afa3263d41788
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3803674Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82155}
    e553a440
web-snapshot.cc 148 KB