• Michael Achenbach's avatar
    Revert "[test] Check for illegal uses of mjsunit methods" · 14c06a34
    Michael Achenbach authored
    This reverts commit a9e93572.
    
    Reason for revert:
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/23956
    Happened already 2 builds earlier, but the output is corrupted due to
    an outage.
    
    Original change's description:
    > [test] Check for illegal uses of mjsunit methods
    > 
    > The assertThrows and assertDoesNotThrow methods expect either a
    > function to execute, or a string to eval. In several tests however we
    > accidentally passed the *result* of the statement to be tested instead
    > of the code.
    > This CL adds check to catch such error early, and removes wrong uses.
    > In most places, we do not need to use assertDoesNotThrow anyway,
    > because exceptions are handled as test failures.
    > 
    > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate
    > MjsUnitAssertionErrors correctly.
    > 
    > R=​mathias@chromium.org
    > 
    > Bug: v8:8562
    > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49
    > Reviewed-on: https://chromium-review.googlesource.com/c/1439238
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#59277}
    
    TBR=ahaas@chromium.org,clemensh@chromium.org,mathias@chromium.org
    
    Change-Id: Iec06c95dd3223f27297e5c6e02835d26b5e753e7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8562
    Reviewed-on: https://chromium-review.googlesource.com/c/1449634Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59284}
    14c06a34
regress-3218530.js 1.83 KB