• Sathya Gunasekaran's avatar
    Revert "Reland "[regexp] Call the regexp interpreter without CEntry overhead"" · aa478cac
    Sathya Gunasekaran authored
    This reverts commit c2ee4a79.
    
    Reason for revert: webgl_conformance_tests deqp/data/gles2/shaders/conversions.html crashes on Android FYI Release (Nexus 9)
    See https://bugs.chromium.org/p/chromium/issues/detail?id=985624
    
    Original change's description:
    > Reland "[regexp] Call the regexp interpreter without CEntry overhead"
    >
    > This is a reland of d4d28b73
    >
    > Original change's description:
    > > [regexp] Call the regexp interpreter without CEntry overhead
    > >
    > > Previously all RegExp calls went through Runtime_RegExpExec when --regexp-interpret-all was set.
    > >
    > > This CL avoids the runtime overhead by calling into the interpreter directly from the RegExpExec Builtin when the regular expression subject was already compiled to ByteCode (i.e. after the first call).
    > >
    > > Bug: v8:8954
    > > Change-Id: Iae9dfcef3370b772a05b2942305335d592f6f15a
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1698391
    > > Commit-Queue: Patrick Thier <pthier@google.com>
    > > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > > Reviewed-by: Peter Marshall <petermarshall@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#62753}
    >
    > Bug: v8:8954
    > Change-Id: I1f0b6de9c6da65bcb582ddb41a37419116a5c510
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1706053
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@google.com>
    > Cr-Commit-Position: refs/heads/master@{#62794}
    
    TBR=jgruber@chromium.org,petermarshall@chromium.org,pthier@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:8954, chromium:985624
    Change-Id: I5bc2c397a09979f42f28670f80a5366f2a33d80f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1709411
    Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62824}
    aa478cac
builtins-regexp-gen.cc 104 KB