• littledan's avatar
    Throw the right exceptions from setting elements in Array.prototype.concat · 7acee1ef
    littledan authored
    This patch fixes two bugs in Array.prototype.concat in conjunction with
    subclassing Arrays:
    - Create a new property rather than calling Set when adding elements to
      the output array. This means setters are not called.
    - If there is an exception thrown from DefineProperty, propagate it
      outwards properly, rather than swallowing it. This can occur, e.g., with
      a Proxy as the new output array.
    
    R=adamk
    LOG=Y
    BUG=chromium:595319
    
    Review URL: https://codereview.chromium.org/1814933002
    
    Cr-Commit-Position: refs/heads/master@{#34876}
    7acee1ef
regress-595319.js 1.35 KB