• Simon Zünd's avatar
    Revert "[array] Prepare Array.p.shift for removal of the JavaScript fall-back" · 28afdca6
    Simon Zünd authored
    This reverts commit f4ca3fc5.
    
    Reason for revert: Since TF (js-call-reducer) calls into the C++ builtin, it is easier (cleaner for now) to implement the baseline version in C++ instead of Torque.
    
    Original change's description:
    > [array] Prepare Array.p.shift for removal of the JavaScript fall-back
    > 
    > This CL changes the ArrayPrototypeShift builtin to a CSA macro which
    > is used in a newly created Torque builtin.
    > 
    > This is in preparation for removing the JavaScript fall-back, which
    > will be replaced by a baseline Torque implementation.
    > 
    > R=​cbruni@chromium.org, jgruber@chromium.org
    > 
    > Bug: v8:7624
    > Change-Id: I9b7898beea2802cc02d394e040a1e500387cf108
    > Reviewed-on: https://chromium-review.googlesource.com/1169172
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Commit-Queue: Simon Zünd <szuend@google.com>
    > Cr-Commit-Position: refs/heads/master@{#55036}
    
    TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:7624
    Change-Id: I4929eefaa90ff8681bc8ae20e3ea3fe84ee7f1e8
    Reviewed-on: https://chromium-review.googlesource.com/1186342Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Simon Zünd <szuend@google.com>
    Cr-Commit-Position: refs/heads/master@{#55345}
    28afdca6
builtins-definitions.h 112 KB