• machenbach's avatar
    Revert of [builtins] Properly optimize TypedArray/DataView accessors.... · d3a43e47
    machenbach authored
    Revert of [builtins] Properly optimize TypedArray/DataView accessors. (patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )
    
    Reason for revert:
    Blink:
    https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7296
    
    Original issue's description:
    > [builtins] Properly optimize TypedArray/DataView accessors.
    >
    > The following getters were moved to the TypedArray/DataView prototype
    > chain with ES2015, and hence need different treatment now:
    >
    > - DataView.prototype.buffer
    > - DataView.prototype.byteLength
    > - DataView.prototype.byteOffset
    > - TypedArray.prototype.buffer
    > - TypedArray.prototype.byteLength
    > - TypedArray.prototype.byteOffset
    > - TypedArray.prototype.length
    >
    > Instead of having special magic on the LoadIC in the IC system and the
    > optimizing compilers, as we used to do before (and which we got rid of
    > already), we just treat those as normal accessors and make them
    > recognizable via the BuiltinFunctionId mechanism. This allows us to
    > remove some of the additional magic from the IC subsystem, and just
    > extend the BuiltinFunctionId mechanism in Crankshaft slightly to cover
    > these cases too (TurboFan doesn't yet support accessors, but that will
    > be fixed soonish anyways).
    >
    > This addresses most of the 15-20% regression we saw on the Octane
    > GameBoy emulator benchmark.
    >
    > BUG=chromium:579905,chromium:593634,v8:4085,v8:5073
    > R=yangguo@chromium.org
    >
    > Committed: https://crrev.com/1ef737026565ea2becc84f30cfd432e581d50c6b
    > Cr-Commit-Position: refs/heads/master@{#36782}
    
    TBR=yangguo@chromium.org,bmeurer@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:579905,chromium:593634,v8:4085,v8:5073
    
    Review-Url: https://codereview.chromium.org/2039093005
    Cr-Commit-Position: refs/heads/master@{#36783}
    d3a43e47
handler-compiler.cc 22.5 KB