• Joey Gouly's avatar
    Reland "[liftoff] Introduce emit_{i64,i32}_add with immediate" · 138d2dfc
    Joey Gouly authored
    This is a reland of e3be96d6
    
    The failure was due to not sign extendint the immediate for 64-bit adds on
    32-bit platforms.
    
    Original change's description:
    > [liftoff] Introduce emit_{i64,i32}_add with immediate
    >
    > This allows immediates to be encoded directly into instructions, rather than
    > mov-ing constants to registers first.
    >
    > This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once
    > this approach has been approved.
    >
    > Bug: v8:9038
    >
    > Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#60506}
    
    Bug: v8:9038
    Change-Id: I7dd1112827d037d900fd36cce71206388642605b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543730Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60521}
    138d2dfc
liftoff-assembler-ia32.h 62.8 KB